fix: use @Feature annotation instead of @Features#707
Conversation
703b577 to
ca63204
Compare
|
seems like some weird behaviour is present on the framework side with the naming helidon-io/helidon#8163 https://helidon.io/docs/v4/apidocs/io.helidon.common.features.api/io/helidon/common/features/api/Feature.html - that's old annotation, but works fine with metadata files. added the potential bug here helidon-io/helidon#10936 . maybe there is some workaround. |
|
@ivanguravel, I don't have the full context, but did you try to modify |
|
@akugal no, but I will try |
|
@ivanguravel it appears that you have unsigned commits which prevents this PR from merging. Could you please sign the commits? |
ca63204 to
4e4bbd6
Compare
|
@anthony-swirldslabs that's done. |
GitHub still says |
Replace deprecated @Features.* annotations with @feature annotation to fix IllegalStateException on startup caused by missing module name in generated feature-metadata.properties. * Replace @Features.Preview with @Preview annotation * Replace @Features.Name, Description, Flavor, Path with @feature * Match annotation pattern used in pbj-grpc-helidon module Fixes: hiero-ledger/hiero-block-node#1964 Signed-off-by: Ivan Zhuravel <ivanguravel@gmail.com>
4e4bbd6 to
9ca3fb5
Compare
|
@anthony-swirldslabs ok. you are about gpg.... I thought about |
|
@ivanguravel Thanks! I just merged it. The fix is being released in PBJ v0.13.1 as we speak (it should be available in Maven in about 20 minutes.) |
|
@anthony-swirldslabs
on the other hand seems like some additional changes have been added into the repo and I did one more fix for the build procedure itself -> line 374: could you please tell me if it's ok to update the |
|
@ivanguravel Thanks for confirming that the PBJ fix works for you! |
|
@ivanguravel thanks! |
|
Hello @anthony-swirldslabs In terms of the following info from the helidon side helidon-io/helidon#10936 (comment) I'm wondering if I should find another way how to resolve that issue with the config exception ? |
|
@ivanguravel : Yes, that would be great. Per the reply from Helidon, it sounds like the best approach would be to switch back to the new annotations (that we used before this PR) AND replace the old processor with the new codegen module. It seems like we just were missing this second part in order to make the new annotations work. |

Description:
Fix
IllegalStateExceptionon Block Node startup caused by invalid Helidon feature metadata.The
pbj-grpc-helidon-configmodule uses@Features.*annotations which don't generate the requiredm(module name) field infeature-metadata.properties. This causes Helidon 4.3.2 to throw an exception during feature scanning.@Features.Previewwith@Previewannotation@Features.Name,@Features.Description,@Features.Flavor,@Features.Pathwith consolidated@Featureannotation (which is old, but works)pbj-grpc-helidonmoduleRelated issue(s):
Fixes hiero-ledger/hiero-block-node#1964
Notes for reviewer:
Before fix -
feature-metadata.propertieswas missingmfield:After fix -
feature-metadata.propertiescontains all required fields:Checklist